Improve client's defaultsMiddleware performance#400
Open
tiagonapoli wants to merge 4 commits intomasterfrom
Open
Improve client's defaultsMiddleware performance#400tiagonapoli wants to merge 4 commits intomasterfrom
tiagonapoli wants to merge 4 commits intomasterfrom
Conversation
fcbd641 to
af526a4
Compare
Signed-off-by: Tiago Martins Nápoli <napoli.tiago96@gmail.com>
Signed-off-by: Tiago Martins Nápoli <napoli.tiago96@gmail.com>
Signed-off-by: Tiago Martins Nápoli <napoli.tiago96@gmail.com>
Signed-off-by: Tiago Martins Nápoli <napoli.tiago96@gmail.com>
af526a4 to
30e7a40
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Running tests on my computer I got around 50% improvement on times to get requests cached on memory.
To check the results you can:
clients-cache-performancenode stressCLI.js @vtex/api 1000 100, which will show the time to do 100 gets using the lib specified in the @vtex/api entry (which is the master branch). Then runnode stressCLI.js @vtex/api1 1000 100, which will show the time to do 100 gets using the lib specified in this entry.You can generate flame graphs too to compare the two libs:
There are flamegraphs that shows how the ramda functions are "hot" (you'll have to clone the repository and access the following):
https://github.com/vtex/dev-tools-experiments/tree/master/clients-cache-performance/memoryCache/flamegraphs
Types of changes