ci: upgrade pnpm/action-setup to v5 and read version from package.json#1785
ci: upgrade pnpm/action-setup to v5 and read version from package.json#1785TooTallNate merged 4 commits intomainfrom
Conversation
Removes hardcoded pnpm version (10.14.0) from all workflows and instead reads the version from the packageManager field in package.json, so CI stays in sync with the version used locally.
|
🧪 E2E Test Results❌ Some tests failed Summary
❌ Failed Tests🌍 Community Worlds (98 failed)mongodb (15 failed):
redis (15 failed):
turso (68 failed):
Details by Category✅ ▲ Vercel Production
✅ 💻 Local Development
✅ 📦 Local Production
✅ 🐘 Local Postgres
✅ 🪟 Windows
❌ 🌍 Community Worlds
✅ 📋 Other
|
📊 Benchmark Results
workflow with no steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Nitro | Next.js (Turbopack) workflow with 1 step💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Nitro | Next.js (Turbopack) workflow with 10 sequential steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Next.js (Turbopack) | Express workflow with 25 sequential steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Express | Next.js (Turbopack) workflow with 50 sequential steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Nitro | Next.js (Turbopack) Promise.all with 10 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) | Express | Nitro Promise.all with 25 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) | Express | Nitro Promise.all with 50 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Express | Next.js (Turbopack) Promise.race with 10 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) | Express | Nitro Promise.race with 25 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Nitro | Next.js (Turbopack) Promise.race with 50 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Express | Next.js (Turbopack) workflow with 10 sequential data payload steps (10KB)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) | Express | Nitro workflow with 25 sequential data payload steps (10KB)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Nitro | Next.js (Turbopack) workflow with 50 sequential data payload steps (10KB)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Express | Next.js (Turbopack) workflow with 10 concurrent data payload steps (10KB)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Next.js (Turbopack) | Nitro workflow with 25 concurrent data payload steps (10KB)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Express | Next.js (Turbopack) workflow with 50 concurrent data payload steps (10KB)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Nitro | Next.js (Turbopack) Stream Benchmarks (includes TTFB metrics)workflow with stream💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Next.js (Turbopack) | Nitro stream pipeline with 5 transform steps (1MB)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) | Nitro | Express 10 parallel streams (1MB each)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Nitro | Next.js (Turbopack) fan-out fan-in 10 streams (1MB each)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Next.js (Turbopack) | Express SummaryFastest Framework by WorldWinner determined by most benchmark wins
Fastest World by FrameworkWinner determined by most benchmark wins
Column Definitions
Worlds:
|
There was a problem hiding this comment.
Pull request overview
Updates GitHub Actions CI workflows to use pnpm/action-setup@v6 and rely on the repository’s package.json#packageManager field for the pnpm version, reducing hardcoded version drift across workflow files.
Changes:
- Bump
pnpm/action-setupfromv3tov6in the affected workflows. - Remove the explicit
with: version: ...pin so pnpm is derived frompackageManagerinpackage.json.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/tests.yml | Upgrades pnpm/action-setup to v6 for the jobs that set pnpm up directly. |
| .github/workflows/release.yml | Uses pnpm/action-setup@v6 and removes the hardcoded pnpm version. |
| .github/workflows/lint.yml | Uses pnpm/action-setup@v6 and removes the hardcoded pnpm version. |
| .github/workflows/docs-checks.yml | Uses pnpm/action-setup@v6 (both jobs) and removes the hardcoded pnpm version. |
| .github/workflows/debug-windows.yml | Uses pnpm/action-setup@v6 and removes the hardcoded pnpm version. |
| .github/workflows/backport.yml | Uses pnpm/action-setup@v6 and removes the hardcoded pnpm version. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
…up@v6 Also removes the pnpm-version input since the action now reads the version from package.json#packageManager.
VaguelySerious
left a comment
There was a problem hiding this comment.
LGTM assuming tests pass
Summary
pnpm/action-setupfromv3tov5across all GitHub Actions workflows (and thesetup-workflow-devcomposite action)version: 10.14.0input so the action reads the pnpm version from thepackageManagerfield inpackage.json(currentlypnpm@10.20.0)pnpm-versioninput from thesetup-workflow-devcomposite actionpackage.jsonWhy
v5instead ofv6?pnpm/action-setup@v6ships with pnpm 11 (RC/beta) as its bundled pnpm. When the project'spackageManagerpins a pnpm 10.x version, pnpm 11 is used as the launcher and the install fails withERR_PNPM_BROKEN_LOCKFILE: expected a single document in the stream. This is a known regression tracked in:v5is the latest stable release beforev6and already supports reading the version frompackageManager, so we still get the drift-elimination benefit without the pnpm 11 breakage.