fix(lazy-dynamic): pass crossOrigin to preload call for next/dynamic chunks#92913
Closed
aphrody-code wants to merge 1 commit intovercel:canaryfrom
Closed
fix(lazy-dynamic): pass crossOrigin to preload call for next/dynamic chunks#92913aphrody-code wants to merge 1 commit intovercel:canaryfrom
aphrody-code wants to merge 1 commit intovercel:canaryfrom
Conversation
…chunks ReactDOM.preload() for next/dynamic scripts was missing crossOrigin, causing CORS warnings when assetPrefix serves assets from another domain. Fixes vercel#92904 vercel#92797
Collaborator
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When
assetPrefixandcrossOriginare configured innext.config.js, theReactDOM.preload()call fornext/dynamicscripts was missing thecrossOriginoption, causing CORS warnings in Chrome when assets are served from a different domain.Fix
Use
process.env.__NEXT_CROSS_ORIGIN(the same env variable used by the client-side route-loader) to pass the configuredcrossOriginvalue topreload(), consistent with how other parts of Next.js handle this.Fixes #92797
Test plan
assetPrefixandcrossOrigininnext.config.jsnext/dynamicto lazy-load a component