Chracter spacing#30
Open
Vladimir-Burshnev wants to merge 5117 commits into
Open
Conversation
[Editor] Remove unused property
…s correct" scripting integration test Typing in the text field causes a sandbox event to trigger, which we should await to avoid continuing to the next part of the test before the sandbox event is fully processed.
…scripting Fix intermittent failure in the "must check that the computed value is correct" scripting integration test
…wed to be printed (bug 1978985)
Disable printing when enablePermission is true and the pdf isn't allowed to be printed (bug 1978985)
…triggered by the pointer or the keyboard (bug 1976597) It's useful for users highlighting with NVDA. They've to enable native selection and then selection some text. In this case only a selectionchange is triggered once the selection is done.
…e browser (bug 1957680) This way, it should unblock zooming with ctrl+wheel after scrolling.
[Editor] Highlight text on a selectionchange event which hasn't been triggered by the pointer or the keyboard (bug 1976597)
Trigger a fake scrollend event in case it hasn't been triggered by the browser (bug 1957680)
The fixed -400px horizontal offset used by scrollIntoView led to horizontal scroll only moving part-way right on narrow screens. The highlights near the right-edge remained party or completely off screen. This centres the highlighted match on any viewport width while clamping the left margin to 20-400px. On very narrow screens the scrollbar now moves all the way to the right instead of stopping midway.
…egistry Lazy initialize FinalizationRegistry used by IccColorSpace.#finalizer
Make horizontal padding relative to device width
In mozilla#20016, the `canvasContext` property of `RenderParameters` was deprecated in favor of the new `canvas` property. The JSDoc was updated to include the new parameter along with the old one. I think the old one should be enclosed in `[]` to mark it as optional (and to allow usage from TypeScript with just the `canvas` parameter provided). I also reordered the properties so that all required properties come first, follow by optional ones.
Mark `canvasContext` as optional
It fixes mozilla#20155.
Update l10n files
Bumps [actions/checkout](https://github.com/actions/checkout) from 4 to 5. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v4...v5) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: '5' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
…ns/actions/checkout-5 Bump actions/checkout from 4 to 5
Check the setDash arguments
…tor toolbar It should fix the error: ``` JavaScript error: http://127.0.0.1:43303/build/generic/build/pdf.mjs, line 1445: TypeError: EventTarget.addEventListener: 'signal' member of AddEventListenerOptions is not an object. ``` we've when running integration tests on the Linux bot.
…on_test [Editor] Avoid to use a null signal when setting listeners in the editor toolbar
…annotation [Editor] Correctly hide deleted annotations
In Chrome protocol calls are faster than in Firefox and thus trigger in quicker succession. This can cause intermittent failures because new protocol calls can run before events triggered by the previous protocol calls had a chance to be processed (essentially causing events to get lost). This commit fixes the issue by configuring Chrome with a protocol call delay value that gives it a more similar execution speed as Firefox (which also gives us more consistency between the two browser runs). Note that this doesn't negatively impact the overall runtime of the integration tests because Puppeteer already waits for a test to complete in both browsers before continuing to the next one and Chrome consistently was, and with this patch still slightly is, faster in completing the tests.
…g" integration test on Windows This is a temporary measure to reduce noise until mozilla#20136 is fixed. Note that this shouldn't be an issue in terms of coverage because we still run the test on Linux.
…-chrome Implement a delay for Chrome protocol calls in the integration tests, and skip the "must check that an existing highlight is ignored on hovering" integration test on Windows
The following preferences don't have to be set manually anymore: - `print.show_print_progress` - Why: removed - Bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1770536 - Commit: mozilla-firefox/firefox@b522664 - `gfx.offscreencanvas.enabled` - Why: removed - Bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1914083 - Commit: mozilla-firefox/firefox@7d2c688 - `layout.css.round.enabled` - Why: removed - Bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1874633 - Commit: mozilla-firefox/firefox@9790965 - `dom.events.asyncClipboard.clipboardItem` - Why: enabled by default - Bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1887845 - Commit: mozilla-firefox/firefox@de56ae8
[Editor] Slightly move the resizer in the sidebar comment in order to make it easier to use (bug 1992385)
Only apply word spacing when there is a 0x20 in the text chunk
…/tar-fs-3.1.1 Bump tar-fs from 3.1.0 to 3.1.1
This patch removes some previous fixes which are now likely fixed by mozilla#17636. Fixes mozilla#20302.
Fix incremental saving with hybrid references
[410225a] Add error handling to structure tree parsing [fc6eb61] Add support for MCR structure tree elements [d46d472] Fix annotations parsing [bd1202a091] Changes required for pdf.js update to 4.4.168 version [795874e] Tagged pdf changes (v2.16.105-taggedPdf-0.1.18). Squashed commits: [5ccd3c5] The glyph has no Unicode value [3e837b2] Minor fixes [cd20ad2] Move if statements to switch [0cffb5d] Remove mcid overriding [558cfe6] Adding annotation indexes [dec34ff] Adding isArray check [6a5260e] Parsing elements without K and Pg [58bf51d] Supporting PDF 2.0 role map [3cc4129] Adding additional checks [025bf9a] Adding roleMapped name to structure elements [1aedabc] Update glyphs position saving [0bee241] Fixes after rebase [5f6b058] Getting MCID for PDF/UA structure elements [5235726] Adding undefined check [b27e4d7] Requested changes [0b71c75] Content is neither marked as Artifact nor tagged as real content fix [e349e7e] Vertical text fix [09f8276] Wrong bounding box for glyphs bug fix [eade1be] Fix issue with empty font matrix [21acb67] Fix issue with empty font matrix [88c2366] Add glyph position detection [5945cf3] Couldn't select Figure elements in 'inspect-document' section (bug fix) (#6) Co-authored-by: Vladimir <vladimir.burshnev@duallab.com> [10b62c6] Incorrect bounding box for content (bug fix) (#5) Co-authored-by: Vladimir <vladimir.burshnev@duallab.com> [0ebdac7] Fix issue with calculating bounding boxes for text (#4) [e2c5571] Fix issue with empty S field [92c0029] Updated current version [54076b5] Added ability to set version manually [efb5a54] Added document structure parsing and bbox-es calculating
Update to v5.4.296
The error artifacts is not highlighted
Return list of fonts
* Add Metadata pop-up (extract encryption dictionary) * Small fix --------- Co-authored-by: Vladimir <vladimir.burshnev@duallab.com>
Co-authored-by: Vladimir <vladimir.burshnev@duallab.com>
Fix font duplication
Fix for detection of marked content position
Fix issue with names decoding
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
|
Important Review skippedToo many files! This PR contains 883 files, which is 733 over the limit of 150. To get a review, narrow the scope: Upgrade to a paid plan to raise the limit. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (285)
📒 Files selected for processing (883)
You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
14 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: https://trello.com/c/SCBNY4Sg