Skip to content

Fix: GitHub branch pagination #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
HarshMN2345 wants to merge 5 commits into
base: main
Choose a base branch
from
+51 −7
Open

Fix: GitHub branch pagination #98

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
78507b1
Fix GitHub branch pagination
HarshMN2345 May 11, 2026
6f3a606
Address GitHub branch pagination review
HarshMN2345 May 12, 2026
67038d7
Merge remote-tracking branch 'origin/main' into claude/nice-elbakyan-…
HarshMN2345 May 13, 2026
a413e42
Implement createBranch, add page param to listBranches, rewrite pagin…
HarshMN2345 May 13, 2026
6e88252
Remove loop from listBranches, use page/perPage for single-page fetch
HarshMN2345 May 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 21 additions & 7 deletions src/VCS/Adapter/Git/GitHub.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,15 @@ public function createFile(string $owner, string $repositoryName, string $filepa
*/
public function createBranch(string $owner, string $repositoryName, string $newBranchName, string $oldBranchName): array
{
throw new Exception("Not implemented");
$latestCommit = $this->getLatestCommit($owner, $repositoryName, $oldBranchName);
$sha = $latestCommit['commitHash'];

$response = $this->call(self::METHOD_POST, "/repos/$owner/$repositoryName/git/refs", ['Authorization' => "Bearer $this->accessToken"], [
'ref' => "refs/heads/$newBranchName",
'sha' => $sha,
]);

return $response['body'] ?? [];
}

/**
Expand Down Expand Up @@ -738,22 +746,28 @@ public function getPullRequestFromBranch(string $owner, string $repositoryName,
*
* @param string $owner Owner name of the repository
* @param string $repositoryName Name of the GitHub repository
* @param int $perPage Number of branches to fetch per page
* @param int $page Page number to start fetching from
* @return array<string> List of branch names as array
*/
public function listBranches(string $owner, string $repositoryName): array
public function listBranches(string $owner, string $repositoryName, int $perPage = 100, int $page = 1): array
{
$url = "/repos/$owner/$repositoryName/branches";
$perPage = min(max($perPage, 1), 100);

$response = $this->call(self::METHOD_GET, $url, ['Authorization' => "Bearer $this->accessToken"]);
$response = $this->call(self::METHOD_GET, $url, ['Authorization' => "Bearer $this->accessToken"], [
'page' => $page,
'per_page' => $perPage,
]);

$statusCode = $response['headers']['status-code'] ?? 0;
$responseBody = $response['body'] ?? [];

$names = [];
foreach ($responseBody as $subarray) {
$names[] = $subarray['name'] ?? '';
if ($statusCode < 200 || $statusCode >= 300 || !is_array($responseBody)) {
return [];
}

return $names;
return array_values(array_map(fn ($branch) => $branch['name'] ?? '', $responseBody));
}

/**
Expand Down
30 changes: 30 additions & 0 deletions tests/VCS/Adapter/GitHubTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -525,6 +525,36 @@ public function testGetCommitWithInvalidHash(): void
}
}

public function testListBranchesPagination(): void
{
$repositoryName = 'test-list-branches-pages-' . \uniqid();
$this->vcsAdapter->createRepository(static::$owner, $repositoryName, false);

try {
$this->vcsAdapter->createFile(static::$owner, $repositoryName, 'README.md', '# Test');
$this->vcsAdapter->createBranch(static::$owner, $repositoryName, 'branch-a', static::$defaultBranch);
$this->vcsAdapter->createBranch(static::$owner, $repositoryName, 'branch-b', static::$defaultBranch);

/** @var GitHub $adapter */
$adapter = $this->vcsAdapter;

$page1 = $adapter->listBranches(static::$owner, $repositoryName, 1, 1);
$this->assertCount(1, $page1);

$page2 = $adapter->listBranches(static::$owner, $repositoryName, 1, 2);
$this->assertCount(1, $page2);

$this->assertNotSame($page1[0], $page2[0]);

$all = $adapter->listBranches(static::$owner, $repositoryName, 100, 1);
$this->assertContains(static::$defaultBranch, $all);
$this->assertContains('branch-a', $all);
$this->assertContains('branch-b', $all);
} finally {
$this->vcsAdapter->deleteRepository(static::$owner, $repositoryName);
}
}

public function testGetLatestCommit(): void
{
$repositoryName = 'test-get-latest-commit-' . \uniqid();
Expand Down
Loading