Skip to content

Costs dataclass#4196

Merged
timothy-nunn merged 4 commits into
mainfrom
Costs-Dataclass
May 6, 2026
Merged

Costs dataclass#4196
timothy-nunn merged 4 commits into
mainfrom
Costs-Dataclass

Conversation

@clmould
Copy link
Copy Markdown
Collaborator

@clmould clmould commented Apr 16, 2026

Description

Checklist

I confirm that I have completed the following checks:

  • My changes follow the PROCESS style guide
  • I have justified any large differences in the regression tests caused by this pull request in the comments.
  • I have added new tests where appropriate for the changes I have made.
  • If I have had to change any existing unit or integration tests, I have justified this change in the pull request comments.
  • If I have made documentation changes, I have checked they render correctly.
  • I have added documentation for my change, if appropriate.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 16, 2026

Codecov Report

❌ Patch coverage is 94.22151% with 36 lines in your changes missing coverage. Please review.
✅ Project coverage is 51.79%. Comparing base (d68ad22) to head (a1d1b2d).

Files with missing lines Patch % Lines
process/models/availability.py 87.77% 11 Missing ⚠️
process/core/solver/constraints.py 50.00% 6 Missing ⚠️
process/core/scan.py 0.00% 4 Missing ⚠️
process/models/costs/costs_2015.py 63.63% 4 Missing ⚠️
process/core/solver/objectives.py 40.00% 3 Missing ⚠️
process/core/solver/evaluators.py 0.00% 2 Missing ⚠️
process/main.py 71.42% 2 Missing ⚠️
process/models/ife.py 33.33% 2 Missing ⚠️
process/core/caller.py 0.00% 1 Missing ⚠️
process/core/final.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4196      +/-   ##
==========================================
- Coverage   52.17%   51.79%   -0.39%     
==========================================
  Files         150      150              
  Lines       30447    30198     -249     
==========================================
- Hits        15886    15640     -246     
+ Misses      14561    14558       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@clmould clmould marked this pull request as ready for review April 16, 2026 16:25
@clmould clmould requested a review from a team as a code owner April 16, 2026 16:25
Comment thread process/main.py
Comment thread process/main.py
@je-cook je-cook added the Data structure Issues related to the data structure label Apr 17, 2026
@timothy-nunn timothy-nunn self-assigned this May 5, 2026
@clmould clmould force-pushed the Costs-Dataclass branch from 75ef0e8 to 0bf17af Compare May 6, 2026 09:26
Comment thread tests/unit/models/stellarator/test_stellarator.py Outdated
Comment thread tests/unit/models/test_costs_2015.py Outdated
Comment thread tests/unit/models/test_costs_2015.py Outdated
Comment thread tests/unit/models/test_costs_2015.py Outdated
Comment thread tests/unit/models/test_costs_2015.py Outdated
Comment thread tests/unit/models/test_costs_2015.py Outdated
Comment thread tests/unit/models/test_costs_2015.py Outdated
Comment thread tests/unit/models/test_ife.py Outdated
Comment thread tests/unit/models/test_ife.py Outdated
Comment thread tests/unit/models/test_power.py Outdated
@clmould clmould requested a review from timothy-nunn May 6, 2026 10:19
@timothy-nunn timothy-nunn merged commit 95d16d1 into main May 6, 2026
10 of 11 checks passed
@timothy-nunn timothy-nunn deleted the Costs-Dataclass branch May 6, 2026 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Data structure Issues related to the data structure

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants