Drop deprecated .navbar-dark remaining usage#42530
Merged
Merged
Conversation
julien-deramond
force-pushed
the
v6-dev-jd-drop-deprecated-navbar-dark
branch
from
c7fdac0 to
f74362a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Spotted by #42487.
The
.navbar-darkclass is now deprecated, and the association.navbar-dark+.bg-darkcan be replaced withdata-bs-theme="dark"directly.The change is applied to all files.
No need to mention in the migration guide, as it was already deprecated in v5.3.0, I suppose.
Live previews