Skip to content

feat(soavec): add SoAVec::iter and SoAVec::iter_mut#44

Merged
omfj merged 2 commits into
mainfrom
omfj/feat/iter
Dec 23, 2025
Merged

feat(soavec): add SoAVec::iter and SoAVec::iter_mut#44
omfj merged 2 commits into
mainfrom
omfj/feat/iter

Conversation

@omfj

@omfj omfj commented Dec 14, 2025

Copy link
Copy Markdown
Collaborator

Adds iter methods to SoAVec.

@omfj omfj force-pushed the omfj/feat/iter branch 3 times, most recently from c95823d to c2d5a33 Compare December 14, 2025 19:50

@aapoalas aapoalas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work! Really clean code, and this should definitely help clean up a lot of code dealing with SoAVecs in tests and so on <3

Comment thread soavec/src/iter.rs
@aapoalas aapoalas self-requested a review December 21, 2025 21:41

@aapoalas aapoalas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lint fails as well.

@omfj

omfj commented Dec 22, 2025

Copy link
Copy Markdown
Collaborator Author

Yes! Forgot about that. Should be fixed now. Also implemented the ExactSizeIterator, but wasn't completely sure on how to use it properly.

@aapoalas aapoalas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good work <3

@omfj omfj merged commit b4d5785 into main Dec 23, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants