Skip to content

feat: wire test collection IDs to all upload steps#1119

Merged
trunk-io[bot] merged 10 commits into
mainfrom
feat/test-collections
Jun 16, 2026
Merged

feat: wire test collection IDs to all upload steps#1119
trunk-io[bot] merged 10 commits into
mainfrom
feat/test-collections

Conversation

@dfrankland

@dfrankland dfrankland commented Jun 12, 2026

Copy link
Copy Markdown
Member

Summary

Wires Trunk Flaky Tests collection IDs to all test upload steps across repos, enabling per-collection flake tracking rather than repo-wide tracking. Adds both staging and prod collection IDs where applicable. Depends on the --test-collection-id CLI flag rename landing first.

PRs

🤖 Generated with Claude Code

dfrankland and others added 3 commits June 12, 2026 15:16
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…TION_ID

Adds test-collection-id input to test_ruby_gem_uploads action and passes
TRUNK_TEST_COLLECTION_ID through all rspec and knapsack upload steps.
Staging (T5yKSn9h) wired in ruby.yml and release_ruby_gem.yml; both
staging and prod (BiBP2neA) wired in smoke_test.yml and smoke_test_main.yml.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@trunk-io

trunk-io Bot commented Jun 12, 2026

Copy link
Copy Markdown

😎 Merged directly without going through the merge queue, as the queue was empty and the PR was up to date with the target branch - details.

@codecov-commenter

codecov-commenter commented Jun 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.65%. Comparing base (8bc1f13) to head (ee53b16).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1119      +/-   ##
==========================================
+ Coverage   82.40%   82.65%   +0.25%     
==========================================
  Files          69       69              
  Lines       15399    15399              
==========================================
+ Hits        12689    12728      +39     
+ Misses       2710     2671      -39     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@trunk-staging-io

trunk-staging-io Bot commented Jun 12, 2026

Copy link
Copy Markdown

Static BadgeStatic BadgeStatic BadgeStatic Badge

Failed Test Failure Summary Logs
variant_quarantine_test should be quarantined when run with variant A test expected the sum of 2 + 2 to be 5, but it was 4, indicating a failing assertion. Logs ↗︎

View Full Report ↗︎Docs

@trunk-io

trunk-io Bot commented Jun 15, 2026

Copy link
Copy Markdown

Static BadgeStatic BadgeStatic BadgeStatic Badge

Failed Test Failure Summary Logs
variant_quarantine_test should be quarantined when run with variant A test expected the sum of 2 + 2 to be 5, but it was actually 4, indicating a failing assertion. Logs ↗︎
variant_quarantine_test should be quarantined when run with variant A test expected the sum of 2 + 2 to be 5, but it was actually 4, indicating a failing assertion. Logs ↗︎

View Full Report ↗︎Docs

dfrankland and others added 3 commits June 15, 2026 16:41
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Comment thread .github/workflows/ruby.yml Outdated
dfrankland and others added 3 commits June 15, 2026 17:54
- Add variant input to test_ruby_gem_uploads action, threaded through
  to regular tests and knapsack steps
- release_ruby_gem.yml: add prod upload with variant per matrix combination
- ruby.yml build job: run tests once with TRUNK_LOCAL_UPLOAD_DIR, upload
  bundle to all four collections via CLI
- ruby.yml test-ruby-gem-uploads job: add prod and smoke test collection
  uploads, add names to all action steps

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…staging upload in release_ruby_gem.yml

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@trunk-io trunk-io Bot merged commit 4d87743 into main Jun 16, 2026
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants