Skip to content

chore(webapp): prevent db:seed script hang#3962

Merged
matt-aitken merged 2 commits into
mainfrom
feature/tri-11005-dbseed-script-hangs-after-success
Jun 16, 2026
Merged

chore(webapp): prevent db:seed script hang#3962
matt-aitken merged 2 commits into
mainfrom
feature/tri-11005-dbseed-script-hangs-after-success

Conversation

@carderne

Copy link
Copy Markdown
Contributor

Currently the db:seed script just hangs on success.

This PR adds process.exit(0) to the finally block after db disconnect so the script exits properly.

@changeset-bot

changeset-bot Bot commented Jun 16, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 0b5a622

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitai Bot commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 3075390d-d0eb-46cf-81fd-43de15776d29

📥 Commits

Reviewing files that changed from the base of the PR and between de84c46 and 0b5a622.

📒 Files selected for processing (1)
  • .server-changes/prevent-db-seed-script-hang.md
🚧 Files skipped from review as they are similar to previous changes (1)
  • .server-changes/prevent-db-seed-script-hang.md
📜 Recent review details
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (14)
  • GitHub Check: webapp / 🧪 Unit Tests: Webapp (3, 10)
  • GitHub Check: webapp / 🧪 Unit Tests: Webapp (7, 10)
  • GitHub Check: webapp / 🧪 Unit Tests: Webapp (5, 10)
  • GitHub Check: webapp / 🧪 Unit Tests: Webapp (10, 10)
  • GitHub Check: webapp / 🧪 Unit Tests: Webapp (8, 10)
  • GitHub Check: webapp / 🧪 Unit Tests: Webapp (6, 10)
  • GitHub Check: webapp / 🧪 Unit Tests: Webapp (1, 10)
  • GitHub Check: webapp / 🧪 Unit Tests: Webapp (9, 10)
  • GitHub Check: webapp / 🧪 Unit Tests: Webapp (2, 10)
  • GitHub Check: webapp / 🧪 Unit Tests: Webapp (4, 10)
  • GitHub Check: e2e-webapp / 🧪 E2E Tests: Webapp
  • GitHub Check: typecheck / typecheck
  • GitHub Check: audit
  • GitHub Check: Analyze (javascript-typescript)

Walkthrough

apps/webapp/seed.mts adds a single process.exit(0) call after the finally cleanup block, ensuring the db:seed script terminates with a success code once seeding and disconnect have completed rather than hanging. A corresponding .server-changes/prevent-db-seed-script-hang.md changelog entry is added to document the fix.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description is incomplete. It lacks required sections from the template: Closes issue reference, checklist, Testing details, and Changelog. Add missing template sections: issue reference (Closes #), completed checklist items, Testing section with test steps, and Changelog section with change description.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: preventing the db:seed script from hanging by adding process.exit(0).
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/tri-11005-dbseed-script-hangs-after-success

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

coderabbitai[bot]

This comment was marked as resolved.

@carderne carderne marked this pull request as ready for review June 16, 2026 10:33
devin-ai-integration[bot]

This comment was marked as resolved.

@matt-aitken matt-aitken enabled auto-merge (squash) June 16, 2026 10:44
@matt-aitken matt-aitken merged commit 19c0763 into main Jun 16, 2026
31 checks passed
@matt-aitken matt-aitken deleted the feature/tri-11005-dbseed-script-hangs-after-success branch June 16, 2026 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants