[pull] master from golang:master#108
Merged
Merged
Conversation
Change-Id: Ica79417b43af8004dc15e4f1e114640b954247af Reviewed-on: https://go-review.googlesource.com/c/go/+/794000 Reviewed-by: David Chase <drchase@google.com> LUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Slightly rewrite some tests to make them portable. Move AMD64-specific ones to simd_amd64_test.go. Change-Id: Ib82f4806e1ae258f4201b98a8eaa15eecb67c71b Reviewed-on: https://go-review.googlesource.com/c/go/+/794084 LUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: David Chase <drchase@google.com>
arm64_*_test.go is not the right naming convention. It should be *_arm64_test.go. Change-Id: I71b798e6b82c236483354a6de85561b2e244c99a Reviewed-on: https://go-review.googlesource.com/c/go/+/794089 Reviewed-by: David Chase <drchase@google.com> LUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
…nd constants Currently, an out-of-bound constant index of GetElem or SetElem can generate code that is failed to verify with the Wasm engine. Fix it by handling out-of-bound constant the same way as dynamic values. Make GetElem/SetElem tests portable. Change-Id: I0e36b48c2b020a24286c257ee2c778b0041993e3 Reviewed-on: https://go-review.googlesource.com/c/go/+/794122 Reviewed-by: David Chase <drchase@google.com> TryBot-Bypass: Cherry Mui <cherryyz@google.com>
For ELF check for the ELF NOBITS section type. Anything in NOBITS is a BSS symbols. For PE look for runtime.bss; for a Go program, anything runtime.bss is a BSS symbol. Fixes #77301 Change-Id: I15b9af4513a5eb0e8955014a12073c2b56bcefab Reviewed-on: https://go-review.googlesource.com/c/go/+/739080 LUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: David Chase <drchase@google.com> Reviewed-by: Emmanuel Odeke <emmanuel@orijtech.com> Reviewed-by: Carlos Amedee <carlos@golang.org> Auto-Submit: Ian Lance Taylor <iant@golang.org>
ReadDir("/dev/fd") on macOS fails during tests with EBADF.
There is a kernel bug where fstat(N) works but lstat("/dev/fd/N")
and fstatat(open("/dev/fd"), "N") both fail when N is a kqueue fd.
Treat EBADF the same way as ENOENT for purposes of continuing
the ReadDir loop. The effect will be that we don't report the open
kqueue fd, but at least we will report everything else.
While we are here, change the lstatat error path to include
the name being lstat'ed, even though it still has operation "fstatat".
This changes the error from:
read_test.go:157: fstatat /dev/fd: bad file descriptor
to:
read_test.go:157: fstatat /dev/fd/3: bad file descriptor
which is more helpful. It also more closely matches older
Go versions that failed with:
read_test.go:157: lstat /dev/fd/3: bad file descriptor
Of course, with the EBADF workaround we should no longer
see any form of this message, but clean it up anyway.
For #80143.
Change-Id: If3e954b523f50d4c3d7046e5401c4b1a6a6a6964
Reviewed-on: https://go-review.googlesource.com/c/go/+/794140
Reviewed-by: Ian Lance Taylor <iant@golang.org>
LUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Damien Neil <dneil@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )