Add ghostel backend#162
Conversation
tpapp
left a comment
tpapp
left a comment
There was a problem hiding this comment.
Thanks, new backends are welcome, I just have some questions.
|
|
||
| (with-eval-after-load 'ghostel | ||
|
|
||
| (defvar ghostel--process) |
There was a problem hiding this comment.
Can you please explain what this is for? You are not setting it anywhere.
There was a problem hiding this comment.
It is used to see if the Julia process is still alive. I've added a comment.
This is a bit dirty because it is an internal variable of ghostel.el but I didn't figure out a better way.
| (defvar ghostel-use-native-pty) | ||
| (defvar ghostel-buffer-name-function) |
There was a problem hiding this comment.
Similarly, what are these for? You are just setting them to nil.
There was a problem hiding this comment.
These are also variables from ghostel.el. The first one controls how the PTY is controlled. Setting it to nil uses the standard Emacs process machinery. Setting ghostel-buffer-name-function) to nil makes sure that ghostel.el does not override the buffer name.
There was a problem hiding this comment.
I also added a short comment for this
2 participants
Adding support for
ghostelterminal backend, adressing #161.It is working fine on my machine; it is behaving like
vterm.I'm not an Elisp expert, so probably the implementation could be more elegant.