docs(issues): specify JoinSet evaluation for JobManager#2001
Merged
josecelano merged 2 commits intoJul 20, 2026
Conversation
josecelano
force-pushed
the
1586-document-joinset-refactor
branch
from
July 20, 2026 11:06
433b20e to
72d7f4b
Compare
There was a problem hiding this comment.
Pull request overview
This PR adds a new local issue specification documenting a proposed refactor to evaluate tokio::task::JoinSet as the task-ownership mechanism for JobManager, and updates the repository spelling dictionary to include the new identifiers used in the spec.
Changes:
- Added a new issue spec (
#1586) describing the currentJobManagerrisks (sequential waiting + detached tasks) and the constraints/acceptance criteria for a futureJoinSet-based design. - Updated
project-words.txtto whitelistJobManagerandJoinSetfor spell-checking.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| project-words.txt | Adds JobManager and JoinSet to the spelling dictionary. |
| docs/issues/open/1586-use-joinset-in-jobmanager.md | New issue specification documenting the JoinSet evaluation and implementation acceptance criteria. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
193
to
197
| jdbe | ||
| JobManager | ||
| Joakim | ||
| JoinSet | ||
| josecelano |
Member
Author
|
ACK 6903bc8 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a local issue specification for evaluating
tokio::task::JoinSetas the task-ownership mechanism forJobManager.The specification:
JoinHandlevalues in newly spawned tasks;The spelling dictionary is updated with the intentional
JoinSetandJobManageridentifiers.Scope
Documentation only. No production code or shutdown behaviour changes are included, and implementation remains intentionally deferred until the broader shutdown architecture is finalized.
Validation
cargo machete --with-metadatacargo deny check banslinter all