fix(skills): string-aware trailing comma stripping for JSONC#571
Open
itxaiohanglover wants to merge 1 commit into
Open
fix(skills): string-aware trailing comma stripping for JSONC#571itxaiohanglover wants to merge 1 commit into
itxaiohanglover wants to merge 1 commit into
Conversation
The regex r',(\s*[}\]])' does not track JSON string boundaries. If a string value contains a comma followed by } or ], the regex incorrectly removes the comma inside the string, corrupting the JSON. Replace with _strip_trailing_commas_jsonc() — a minimal stateful parser that skips over quoted strings and only strips commas that are followed by } or ] outside of strings. Fixes tirth8205#553
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #553
Problem
The regex
r',(\s*[}\]])'inskills.py:351strips trailing commas before}or], but does not track JSON string boundaries. If a string value contains a comma followed by}or]on the next line, the regex incorrectly removes the comma inside the string, corrupting the JSON.Example breakage:
{ "mcp": { "my-server": { "description": "foo, bar", } } }The comma in
"foo, bar"gets removed →"foo bar"— silently corrupting user config.What changed
Replaced the regex with
_strip_trailing_commas_jsonc()— a minimal stateful parser that:in_stringstate (toggles on"outside of escape sequences)}or]outside of strings\",\\) correctlyNo new dependencies. No existing comments modified.
Validation
json.loads(stripped)call on line 353 works unchanged,}or,]patterns are preserved