feat(igc): enable multi-queue tx/rx#693
Merged
Merged
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends the Intel IGC (I225/I226) driver to support multiple TX/RX queues, aligning the driver with the kernel networking stack’s multi-queue model and MSI-X queue interrupt layout.
Changes:
- Added a per-queue service routine and updated the interrupt/tick paths to service RX and TX reclaim per queue.
- Removed single-queue constraints in TX/RX paths and updated TX reclaim (
igc_txeof) call sites to be queue-aware. - Introduced queue-count selection based on available MSI-X vectors and CPU count (capped to 4), and enabled MSI-X masks for all queue vectors plus the event/link vector.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
atsushi421
reviewed
Jun 1, 2026
- intr: accumulate errors from service_queue/link handlers instead of using `?` so EIMS/IMS re-arm writes always execute and the interrupt line is never left permanently masked - igc_send, igc_rx_recv: guard against out-of-range que_id with an early Err(Param) return to prevent index-out-of-bounds panic - can_send: remove igc_txeof call; descriptor reclaim is the ISR's responsibility and calling it here contends with the ISR TX lock path - igc_select_num_queues: add doc comment explaining the three constraints (MSI-X vectors, CPU count, hard cap of 4) and the rationale for power-of-two rounding for even RETA distribution - igc_txeof: add comment explaining why _que_id is unused Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
atsushi421
approved these changes
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds multi-queue TX/RX support to the IGC driver. It is the fifth step in the incremental IGC bring-up stack; PR4 (#691) must be merged before this one.
Related links
How was this PR tested?
Notes for reviewers