Skip to content
This repository was archived by the owner on Mar 17, 2026. It is now read-only.

Enable to use newer protobuf#415

Open
dskkato wants to merge 3 commits into
tensorflow:masterfrom
dskkato:protobuf
Open

Enable to use newer protobuf#415
dskkato wants to merge 3 commits into
tensorflow:masterfrom
dskkato:protobuf

Conversation

@dskkato

@dskkato dskkato commented Sep 12, 2023

Copy link
Copy Markdown
Contributor
  • remove protobuf version restriction
  • fix CI

Closes #414

@dskkato

dskkato commented Sep 12, 2023

Copy link
Copy Markdown
Contributor Author

@adamcrume Could you check this PR if you have time?

@adamcrume

Copy link
Copy Markdown
Contributor

The problem is that the generated code (which is checked in) is only compatible with the exact same version of protobuf that generated it. This is a very annoying property of the protobuf crate, but I can't change that.

We could switch to generating the code in a build script, which means that we need the proto files available at build time. We could do that by adding TensorFlow as a git submodule, but it's huge (hundreds of megabytes), and apparently cargo doesn't work well with submodules (rust-lang/cargo#7987). Possibly a better way is to just manually (with a script) copy the protos from TensorFlow into this crate for each version upgrade.

@dskkato

dskkato commented Sep 17, 2023

Copy link
Copy Markdown
Contributor Author

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incompatible with projects using protobuf 2.28

2 participants