Update core/download docstrings#2149
Open
sharanramjee wants to merge 13 commits intotensorflow:masterfrom
Open
Update core/download docstrings#2149sharanramjee wants to merge 13 commits intotensorflow:masterfrom
sharanramjee wants to merge 13 commits intotensorflow:masterfrom
Conversation
Conchylicultor
suggested changes
Jul 6, 2020
Contributor
Conchylicultor
left a comment
There was a problem hiding this comment.
Thank you for trying to make our code to looks better.
However, my feeling is that we shouldn't spend too much time on those cosmetic changes when there are much more important / impactful tasks to do.
For instance, changing:
def asdict(self) -> Dict[str, Any]:
"""Returns the dict representation of the dataclass."""To:
def asdict(self) -> Dict[str, Any]:
"""Returns the dict representation of the dataclass.
Returns:
Dict representation of the dataclass.
"""Doesn't add really any value (neither for the developer, nor for the final user).
When you have a limited number of time, you should try focussing on things which really matter. For instance adding new features. It would also be much more interesting for you.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updated docstrings and fixed old pylint errors in core/download files.