Fix pylint errors in Image Classification datasets#1774
Open
vijayphoenix wants to merge 2 commits intotensorflow:masterfrom
Open
Fix pylint errors in Image Classification datasets#1774vijayphoenix wants to merge 2 commits intotensorflow:masterfrom
vijayphoenix wants to merge 2 commits intotensorflow:masterfrom
Conversation
tfds-bot
added
the
community:please_review
sherry-s-yuan
left a comment
sherry-s-yuan
left a comment
There was a problem hiding this comment.
Just some suggestions: change names of the split generator to tfds.Split.Test etc. One example of such is in file cars196.py line 184, 197. This will make maintenance an easier process in the future. Thank you for your hard work fixing these! Everything looks fine except those small places, if fixing these small things is too annoying, feel free to just submit as it is.
tfds-bot
added
author:please_respond
…pylint-image-classification
tfds-bot
added
community:is_reviewing
NikhilBartwal
approved these changes
Dec 14, 2020
tfds-bot
added
tfds:please_review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix some of #1644