Ensure errors don't cause silent failure, make authN failure messages friendlier#89
Open
jeri-temporal wants to merge 4 commits into
Open
Ensure errors don't cause silent failure, make authN failure messages friendlier#89jeri-temporal wants to merge 4 commits into
jeri-temporal wants to merge 4 commits into
Conversation
4dd7046 to
dde51ca
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
commands_test.gotocommon_test.goso it could be used for unit tests as wellFriendlyErrortype as a means of marking error messages for direct display without appending the full error chainerrors.Is/errors.Asto findFriendlyErrors that occur inside gRPC callback methodsWhy?
Running commands while not logged in (including
temporal cloud whoami) produces no output and a non-zero exit code, and other errors are similarly swallowed unless handled specifically within each command.Checklist
Closes CLDDX-141
How was this tested:
make,make test,make test-integration, verified that running commands liketemporal cloud whoamiortemporal cloud namespace listwithout being authenticated printsno login session found, please run `temporal cloud login`Any docs updates needed?
No