Skip to content

chore: align with upstream changes from Node qs v6.15.2#52

Merged
techouse merged 5 commits into
mainfrom
chore/upstream-fixes
May 20, 2026
Merged

chore: align with upstream changes from Node qs v6.15.2#52
techouse merged 5 commits into
mainfrom
chore/upstream-fixes

Conversation

@techouse
Copy link
Copy Markdown
Owner

This pull request updates the Python qs_codec package to align its encode and decode behavior with Node qs version 6.15.2, ensuring improved compatibility and correctness. The changes include bug fixes to key normalization and delimiter handling, dependency updates for comparison tests, and new or updated tests to verify the new behavior.

Compatibility and Bug Fixes:

  • The decode function now normalizes dotted keys before preserving them when depth=0 and allow_dots=True, matching Node qs 6.15.2 behavior. [1] [2] [3] [4]
  • The encode function now uses the configured delimiter after the charset_sentinel token, aligning with the latest Node qs behavior. [1] [2]

Dependency and Test Infrastructure Updates:

  • Updated the comparison test suite to use qs@6.15.2 and switched from npm to pnpm for dependency installation, ensuring tests run against the correct Node.js version. [1] [2] [3] [4] [5]

Testing Improvements:

  • Added and updated tests to verify correct handling of dotted keys with depth=0, delimiter configuration with charset_sentinel, and filtering/encoding of None and Undefined values in both top-level and list contexts. [1] [2] [3] [4]

Documentation:

  • Updated CHANGELOG.md to document the bug fixes and compatibility improvements in version 1.5.1-dev.

@techouse techouse requested a review from Copilot May 19, 2026 18:12
@techouse techouse self-assigned this May 19, 2026
@techouse techouse added the bug Something isn't working label May 19, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 19, 2026

Warning

Rate limit exceeded

@techouse has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 21 minutes and 21 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: f4c64344-bbf3-4aa2-997c-8138c3187ff7

📥 Commits

Reviewing files that changed from the base of the PR and between e96fb40 and d390fb8.

⛔ Files ignored due to path filters (1)
  • tests/comparison/pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (7)
  • CHANGELOG.md
  • CONTRIBUTING.md
  • src/qs_codec/encode.py
  • src/qs_codec/utils/decode_utils.py
  • tests/comparison/package.json
  • tests/unit/decode_test.py
  • tests/unit/encode_test.py
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/upstream-fixes

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codacy-production
Copy link
Copy Markdown

codacy-production Bot commented May 19, 2026

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity · 0 duplication

Metric Results
Complexity 0
Duplication 0

View in Codacy

🟢 Coverage 100.00% diff coverage · +0.00% coverage variation

Metric Results
Coverage variation +0.00% coverage variation (-1.00%)
Diff coverage 100.00% diff coverage

View coverage diff in Codacy

Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (e96fb40) 1904 1904 100.00%
Head commit (d390fb8) 1904 (+0) 1904 (+0) 100.00% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#52) 4 4 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (e96fb40) to head (d390fb8).

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #52   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           22        22           
  Lines         1904      1904           
=========================================
  Hits          1904      1904           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@techouse techouse merged commit 96140c2 into main May 20, 2026
44 of 46 checks passed
@techouse techouse deleted the chore/upstream-fixes branch May 20, 2026 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants