Geminiv3 migration#73
Open
marcinvalas wants to merge 6 commits into
Open
Conversation
marcinvalas
commented
Jul 14, 2026
|
|
||
| private isSnapshot(message: GeminiV3DepthUpdate) { | ||
| if (this.options.isSnapshotDeterminedByEqualUpdateIds) { | ||
| return message.U === message.u |
Contributor
Author
There was a problem hiding this comment.
Because currently update and snapshot messages are exactly the same, later when we do reply, we are not able to identify which message is "update" or "snapshot".
When streaming (or in recorder), we know it since snapshots are the first message.
I found that U and u are equal for snapshots, but it looks like it is not reliable because it could also means exactly one update, so can I modify the channel name to determine if the message is a snapshot? I would add @snapshot postfix: depth@100ms -> depth@100ms@snapshot?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.