Fix/comp terminal predicate rtl#305
Open
guosran wants to merge 1 commit into
Open
Conversation
This was referenced Jun 24, 2026
Collaborator
Author
|
This PR is intentionally separated from #297 because the predicate semantics may need discussion. The intended case is terminal loop comparison: when the vector factor is reached, |
354fcb1 to
abcbc50
Compare
abcbc50 to
794c491
Compare
Collaborator
Author
|
Concrete example: input payload = 7, predicate = 1 Expected: If predicate is 0: |
tancheng
reviewed
Jun 26, 2026
794c491 to
924a63c
Compare
tancheng
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses #292 with a minimized terminal compare predicate fix. This PR only updates
CompRTL.pyand its focused test.Changes
EQ_CONST/NE_CONSTcomparisons produce the loop-control predicate when the vector factor is reached.No new ports or interfaces are introduced.