Skip to content

@W-22865124 Update Python Client library for 262#20

Open
rjiangsalesforce wants to merge 9 commits into
mainfrom
rjiang-262-update
Open

@W-22865124 Update Python Client library for 262#20
rjiangsalesforce wants to merge 9 commits into
mainfrom
rjiang-262-update

Conversation

@rjiangsalesforce

Copy link
Copy Markdown
Collaborator

Pull Request

Description

Updating the python client for the 262 release of VizQL Data Service.

Fixes:

Type of Change

Please delete options that are not relevant.

  • Bug fix
  • New feature
  • Documentation update
  • Refactor
  • Other (describe): Schema update + test updates

Checklist

  • I have read the contributing guidelines
  • I have added tests where applicable
  • I have updated documentation where applicable
  • I have added a clear title to this PR
  • My changes follow the project's coding style
  • I have checked for sensitive information (e.g., no secrets or passwords)

Screenshots (if applicable)

Add screenshots or code snippets if this PR changes UI or major behavior.

Additional Notes

Anything else reviewers should know.

@github-actions

Copy link
Copy Markdown

Code Coverage

Package Line Rate Health
src 100%
src.api 96%
tests 100%
Summary 98% (1329 / 1358)

1 similar comment
@github-actions

Copy link
Copy Markdown

Code Coverage

Package Line Rate Health
src 100%
src.api 96%
tests 100%
Summary 98% (1329 / 1358)

if jwt_token:
auth: Union[TSC.JWTAuth, TSC.PersonalAccessTokenAuth, TSC.TableauAuth] = (
TSC.JWTAuth(jwt_token, site_id)
TSC.JWTAuth(jwt_token, site_id=site_id)

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was this assignment required in python older version?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i had to add this assignment because the tableau server client project updated their params list for their JWTAuth method. that being said, i might need to change this to get the project compiling for python 3.9, which is failing in the pipeline right now

@yunlong-zhang-sfdc

Copy link
Copy Markdown
Collaborator

I was wondering if we need to add some examples for the live workbook queries??

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants