fix(skills): load ray-data and ray-train by quoting YAML extras#196
Open
Yiğit ERDOĞAN (Yigtwxx) wants to merge 1 commit into
Open
fix(skills): load ray-data and ray-train by quoting YAML extras#196Yiğit ERDOĞAN (Yigtwxx) wants to merge 1 commit into
Yiğit ERDOĞAN (Yigtwxx) wants to merge 1 commit into
Conversation
Both SKILL.md files declared dependencies as [ray[data], ...] and [ray[train], ...]. In a YAML flow sequence the inner [ opens a nested sequence, so gray-matter/js-yaml cannot parse the frontmatter. The skill loader catches the parse failure and drops both skills, so they never appear in `skill list`, the / picker, or the Skills panel, with no user-visible error. Quote the extras so each entry is a plain scalar. Add a test that parses every bundled SKILL.md and validates its skill frontmatter, so a malformed block fails CI instead of silently dropping a skill. Fixes synthetic-sciences#187
|
Yiğit ERDOĞAN (@Yigtwxx) is attempting to deploy a commit to the InkVell Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes two bundled skills,
ray-dataandray-train, that never load.Their frontmatter declared dependencies as
[ray[data], ...]and[ray[train], ...]. Inside a YAML flow sequence the[inray[data]opens a nested sequence, sogray-matter/js-yamlcannot parse the frontmatter.Skill.compute()catches the parse error and drops the skill, so both were missing fromskill list, the/picker, and the Skills panel with no user-visible error. Quoting the extras makes each entry a plain scalar and both skills load again.I also added a test that parses every bundled
SKILL.mdand validates its frontmatter, so a malformed block fails the suite instead of silently dropping a skill.Fixes #187
How did you verify your code works?
test/skill/bundled-skills.test.ts. It fails on the two files before the quoting change and passes after.bun testinbackend/cli: the new tests pass and there are no new failures versus the base branch.openscience skill list --allnow listsray-dataandray-train.Checklist
bun run typecheckpassesbun test(inbackend/cli) passesbunx prettier --check .is cleanFixes #187)