Route OpenScience Codex OAuth sessions through Codex handling#150
Open
Seho Son (sayhoson) wants to merge 3 commits into
Open
Route OpenScience Codex OAuth sessions through Codex handling#150Seho Son (sayhoson) wants to merge 3 commits into
Seho Son (sayhoson) wants to merge 3 commits into
Conversation
Constraint: OpenScience exposes subscription access as openai-codex, not plain openai. Rejected: Treat all OpenAI OAuth sessions as Codex | plain OpenAI OAuth must not inherit Codex request shaping. Confidence: high Scope-risk: narrow Directive: Keep subscription-specific request shaping keyed to openai-codex OAuth credentials. Tested: bun test test/session/llm.test.ts test/plugin/codex-401-retry.test.ts test/plugin/codex-refresh.test.ts test/session/billing-gate.test.ts; bun run typecheck; live streamText smoke openai-codex/gpt-5.4-mini returned openscience-codex-ok. Not-tested: Browser interactive connect callback completion; live smoke reused existing Codex OAuth refresh token.
|
Seho Son (@sayhoson) is attempting to deploy a commit to the InkVell Team on Vercel. A member of the Team first needs to authorize it. |
Aayam Bansal (aayambansal)
force-pushed
the
main
branch
2 times, most recently
from
01f4df1 to
2c0487f
Compare
Codex subscription auth and Atlas graph auth are separate. Preserve backend failure details so the canvas tells users when Atlas login is the missing piece. Constraint: Atlas project graphs use the managed OpenScience session, while Codex OAuth can still be valid. Rejected: Treat null project_id as a generic backend failure | hid the unauthenticated Atlas response. Confidence: high Scope-risk: narrow Directive: Keep Codex subscription messaging separate from Atlas graph setup messaging. Tested: bun run --cwd frontend/workspace build; Playwright clicked initialize graph and observed the Atlas login toast; /provider exposes openai-codex models. Not-tested: bun run --cwd frontend/workspace typecheck (blocked by Windows checkout of symlink src/custom-elements.d.ts as a text path); gitleaks (not installed on PATH).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
openai-codexOAuth models as Codex subscription sessions inLLM.stream.openaiOAuth from receiving Codex-specific request shaping.Verification
bun test test/session/llm.test.ts test/plugin/codex-401-retry.test.ts test/plugin/codex-refresh.test.ts test/session/billing-gate.test.ts-> 24 pass, 0 fail.bun run typecheckinbackend/cli-> pass.streamTextagainstopenai-codex/gpt-5.4-mini-> returnedopenscience-codex-ok.gitleaks git --pre-commit --staged --verbose-> no leaks found.Notes
sayhoson, so this PR is from a fork branch.frontend/workspace/src/custom-elements.d.tsis a tracked symlink (mode120000) that this Windows checkout exposes as text, causing full workspace typecheck to fail before push. The changed CLI package was typechecked separately.