[codex] add public contact payments#924
Conversation
0a2aea4 to
c005917
Compare
Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Quick testing notes:
Screen.Recording.2026-05-04.at.22.14.04.mov
|
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9a25b62edc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (refresh) { | ||
| lightningRepo.executeWhenNodeRunning( | ||
| operationName = "sync public Paykit endpoints", | ||
| ) { | ||
| Result.success(Unit) | ||
| }.getOrThrow() |
There was a problem hiding this comment.
Remove unconditional node-running gate before endpoint build
syncPublishedEndpoints(publish = true) now always calls buildWalletEndpoints(refresh = true), and this block hard-fails unless the Lightning node is running. That prevents enabling public contact payments even when an on-chain address is already available, because the method throws before it even checks walletState.onchainAddress. In practice, users who toggle sharing while the node is stopped will get an error and cannot save the setting, despite having a valid publishable endpoint.
Useful? React with 👍 / 👎.
|
@piotr-iohk payment issue with LN seems like RGS error from the logs |



Description
Adds public Paykit payments to contacts on Android, matching the iOS public payments flow and the Paykit endpoint identifier spec.
Preview
N/A
QA Notes
Suggested reviewer checks:
Sent to {name}/Received from {name}titles.