Skip to content

BridgeJS: Fix optionals build error with Embedded Swift #734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
krodak wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −3
Open

BridgeJS: Fix optionals build error with Embedded Swift #734

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Sources/JavaScriptKit/BridgeJSIntrinsics.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,13 +182,13 @@ extension _BridgedSwiftStackType {

/// Types that bridge with the same (isSome, value) ABI as Optional.
/// Used by JSUndefinedOr so all bridge methods delegate to Optional<Wrapped>.
@_spi(BridgeJS) public protocol _BridgedAsOptional {
public protocol _BridgedAsOptional {
associatedtype Wrapped
var asOptional: Wrapped? { get }
init(optional: Wrapped?)
}

@_spi(BridgeJS) extension Optional: _BridgedAsOptional {
extension Optional: _BridgedAsOptional {
public var asOptional: Wrapped? { self }
public init(optional: Wrapped?) { self = optional }
}
Expand Down
2 changes: 1 addition & 1 deletion Sources/JavaScriptKit/JSUndefinedOr.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,4 +53,4 @@ extension JSUndefinedOr: ConvertibleToJSValue where Wrapped: ConvertibleToJSValu

// MARK: - BridgeJS (via _BridgedAsOptional in BridgeJSIntrinsics)

@_spi(BridgeJS) extension JSUndefinedOr: _BridgedAsOptional {}
extension JSUndefinedOr: _BridgedAsOptional {}
Loading