feat(wallets): reuse WalletConnect sessions and pairings#45
Open
feat(wallets): reuse WalletConnect sessions and pairings#45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@swapkit/walletsProblem
The current connector always disconnects the first existing WalletConnect session before connecting again. That breaks normal session restoration and makes chain expansion unnecessarily destructive.
What changed
accountsandsessionupdated from WalletConnect session lifecycle eventsNotes
This keeps the external
WalletOption.WALLETCONNECTAPI intact.It does not migrate the modal UI to Reown AppKit yet; this PR is scoped to session reuse and add-chain behavior.
Verification
bun run --filter @swapkit/wallets buildtscoutput filtered towalletconnect/index.tsandwalletconnect/evmSigner.tscame back cleantscin this worktree still has broader workspace-resolution noise unrelated to this change