Consistently use local database as the default#5145
Open
icopp wants to merge 1 commit intosupabase:developfrom
Open
Consistently use local database as the default#5145icopp wants to merge 1 commit intosupabase:developfrom
icopp wants to merge 1 commit intosupabase:developfrom
Conversation
The codebase currently has a truly nightmare state of commands randomly defaulting to the linked project or the local database depending on specific command, including some commands that mutate the database like `migration repair`. This change makes them all consistently default to the local database only, explicitly requiring `--linked` or `--db-url` to do anything destructive to another database. The change in default behavior will likely take a major version bump, but should save a lot of people from pain in the future. For an example, see: supabase#3493
icopp
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
The codebase currently has a truly nightmare state of commands randomly defaulting to the linked project or the local database depending on specific command, including some commands that mutate the database like
migration repair. This change makes them all consistently default to the local database only, explicitly requiring--linkedor--db-urlto do anything destructive to another database. The change in default behavior will likely take a major version bump, but should save a lot of people from pain in the future.What is the current behavior?
The only way to know which commands default to local behavior and which default to remote behavior is to individually look at the docs of every command.
See for example, #3493
What is the new behavior?
Every command defaults to local. A user must explicitly use
--linkedor--db-urlto do anything that reads or affects anything but the local dev database.