fix: add missing stacklevel=2 to 14 warnings.warn() calls (Fixes #1164)#1165
Open
rtmalikian wants to merge 1 commit into
Open
fix: add missing stacklevel=2 to 14 warnings.warn() calls (Fixes #1164)#1165rtmalikian wants to merge 1 commit into
rtmalikian wants to merge 1 commit into
Conversation
Add stacklevel=2 to all warnings.warn() calls that were missing it, so warnings correctly point to the caller's code instead of library internals. Affected files: - pyhealth/data/__init__.py — 1 call (Visit deprecation) - pyhealth/datasets/__init__.py — 4 calls (deprecated dataset classes) - pyhealth/datasets/mimic3.py — 1 call (prescriptions timestamp) - pyhealth/datasets/mimic4.py — 2 calls (discharge timestamps) - pyhealth/models/concare.py — 1 call (nested_sequence warning) - pyhealth/models/stagenet.py — 2 calls (time/mask warnings) - pyhealth/models/stagenet_mha.py — 2 calls (time/mask warnings) - pyhealth/models/text_embedding.py — 1 call (chunk truncation) Fixes sunlabuiuc#1164 Signed-off-by: rtmalikian <rtmalikian@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1164
Summary
Add
stacklevel=2to 14warnings.warn()calls across 8 files that were missing it. Withoutstacklevel=2, warnings point to library internals instead of the user's code, making them confusing and hard to act on.Changes
pyhealth/data/__init__.pypyhealth/datasets/__init__.pypyhealth/datasets/mimic3.pypyhealth/datasets/mimic4.pypyhealth/models/concare.pypyhealth/models/stagenet.pypyhealth/models/stagenet_mha.pypyhealth/models/text_embedding.pyVerification
Changelog
About the Author: Raphael Malikian — Clinical AI Solutions Architect. I specialise in building and fixing AI/ML systems for healthcare, including vector databases, RAG pipelines, and clinical NLP. If you need help with your project or think I can add value to your organisation, feel free to reach out — I'd love to connect.
📧 rtmalikian@gmail.com
🔗 GitHub: https://github.com/rtmalikian
🔗 LinkedIn: http://www.linkedin.com/in/raphael-t-malikian-mbbs-bsc-hons-71075436a
Disclosure: This code was developed with assistance from mimo-v2.5-pro (Xiaomi) via Hermes Agent (Nous Research). All changes were reviewed, tested against the actual codebase, and verified for correctness.