fix: Game settings config overrides not working properly#3272
Open
ferafiks wants to merge 5 commits into
Open
Conversation
…ter aren't used as the default on all devices
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Details
Currently there is an issue with using config overrides, where the
Specific Filterfield doesn't actually do anything. This is becausePlatformConfigurationhas two static fields that are never set which are used to determine the user's graphics card and cpu model.This PR fixes this and changes some of the logic that is used when choosing the correct configuration:
Sidenote, this feature is extremely useless. Aside from setting a different graphics level, there is almost never a need to use a different config based on the user's platform or gpu. However, this might change in the future if the configurations will contain other settings, so maybe it's not a bad idea to keep this feature.
Types of changes
Checklist