Skip to content

fix: Game settings config overrides not working properly#3272

Open
ferafiks wants to merge 5 commits into
stride3d:masterfrom
ferafiks:config-overrides
Open

fix: Game settings config overrides not working properly#3272
ferafiks wants to merge 5 commits into
stride3d:masterfrom
ferafiks:config-overrides

Conversation

@ferafiks

Copy link
Copy Markdown
Contributor

PR Details

Currently there is an issue with using config overrides, where the Specific Filter field doesn't actually do anything. This is because PlatformConfiguration has two static fields that are never set which are used to determine the user's graphics card and cpu model.

This PR fixes this and changes some of the logic that is used when choosing the correct configuration:

  • Specific filter can now be used to filter the gpu, but not the cpu because I'm not sure if Stride even stores that property anywhere.
  • Configuration overrides are now prioritized from last to first, so that the behavior is more intuitive.
  • Overrides with specific filters remain prioritized over those without one.

Sidenote, this feature is extremely useless. Aside from setting a different graphics level, there is almost never a need to use a different config based on the user's platform or gpu. However, this might change in the future if the configurations will contain other settings, so maybe it's not a bad idea to keep this feature.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My change requires a change to the documentation.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have built and run the editor to try this change out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant