fix(assert): pass custom message through InEpsilonSlice#1899
Open
wyf027 wants to merge 1 commit into
Open
Conversation
InEpsilonSlice delegates to InEpsilon per element but did not forward msgAndArgs, so failure output omitted caller-provided context. Forward the message args alongside the existing index hint. Fixes stretchr#763 Co-authored-by: Cursor <cursoragent@cursor.com>
| 0.04, | ||
| "custom context", | ||
| ) | ||
| Contains(t, mockT.errorString(), "custom context") |
Contributor
There was a problem hiding this comment.
Would it be possible to assert the full error here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
InEpsilonSlicenow forwardsmsgAndArgsto each per-elementInEpsiloncall"at index %d"hint and appends caller-provided contextFixes #763
Problem
InEpsilonSliceloops over elements and callsInEpsilon, but only passed an index hint and omittedmsgAndArgs. Failures therefore lacked caller-provided context that other assertions include underMessages:.InDeltaSlicealready forwardedmsgAndArgs; this alignsInEpsilonSlicewith that behavior.Test plan
go test ./assert/ -run TestInEpsilonSlice -vTestInEpsilonSliceMessageverifying custom message appears in failure output