Fix misleading [BrowserMessage] log tag on generic source ops#1725
Open
summeroff wants to merge 1 commit into
Open
Fix misleading [BrowserMessage] log tag on generic source ops#1725summeroff wants to merge 1 commit into
summeroff wants to merge 1 commit into
Conversation
osn::Source::Update, osn::Source::SendMessage, and CallbackManager's source-message pump are generic obs_source operations, not browser specific. Retag their logs [BrowserMessage] -> [osn-source] so log triage isn't misdirected. No behavior change. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Three OSN log lines were tagged
[BrowserMessage]but actually log genericobs_sourceoperations, not browser-specific ones:osn::Source::Update(osn-source.cpp) — generic source settings updateosn::Source::SendMessage(osn-source.cpp) — calls genericobs_source_send_messageCallbackManager::GlobalQuery(callback-manager.cpp) — pumpsobs_source_get_messagesfor all sourcesThis misdirects log/crash triage — e.g. a media-source settings update shows up as a
[BrowserMessage].Change
Retag those three logs
[BrowserMessage]->[osn-source]. String-literal text only: no logic, format specifiers, or behavior change. The genuinely browser-specific[BrowserMessage]logs in theobs-browserplugin are intentionally left untouched.Testing
Log-string-only change; no functional impact. Not separately built locally (string-literal edit with identical
%s/%lluspecifiers and arg counts).🤖 Generated with Claude Code