osn-input: log source id before creating input#1721
Open
summeroff wants to merge 1 commit into
Open
Conversation
Records the source id (after the _vN suffix) before obs_source_create, so a crash during creation leaves the offending source as the last line in the log. Input::Create is infrequent, so the INFO log is cheap. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds additional logging in osn::Input::Create to help identify which OBS input source ID was being created immediately before calling obs_source_create, improving crash forensics when source creation faults.
Changes:
- Log the resolved input
sourceId(after any_vNversion suffix) immediately beforeobs_source_create. - Add a short explanatory comment indicating the log is intentionally placed before the create call.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an INFO log of the input source id (after the
_vNsuffix) and its name immediately beforeobs_source_createinInput::Create.Source-create crashes have appeared in Sentry with no indication of which source triggered them (the crash breadcrumb records only
Input::Create, not its args). Logging the id and name just before the create call leaves the offending source as the last line in the log whenobs_source_createfaults.Input::Createis infrequent, so the extra log is cheap.Companion to streamlabs/obs-studio#735.
🤖 Generated with Claude Code