Skip to content

Expose activate_by_signed_key#481

Merged
jbaublitz merged 1 commit into
stratis-storage:masterfrom
crumblingMizzle:master
May 20, 2026
Merged

Expose activate_by_signed_key#481
jbaublitz merged 1 commit into
stratis-storage:masterfrom
crumblingMizzle:master

Conversation

@crumblingMizzle
Copy link
Copy Markdown
Contributor

No description provided.

@packit-as-a-service
Copy link
Copy Markdown

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo dnf install -y 'dnf*-command(copr)'
  • dnf copr enable packit/stratis-storage-libcryptsetup-rs-481
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

Copy link
Copy Markdown
Member

@jbaublitz jbaublitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @crumblingMizzle, thanks so much for the contribution! We support versions as old as 2.2.0 so you will need to follow the pattern for feature flagging this method for versions after 2.3.0. I did some digging in git and it appears that's the version when this method was added. You can find some examples in our code.

@mulkieran mulkieran moved this from Todo to In Progress in 2026May May 19, 2026
@crumblingMizzle crumblingMizzle requested a review from jbaublitz May 19, 2026 15:44
@crumblingMizzle
Copy link
Copy Markdown
Contributor Author

Great point, thank you! Properly squashed the commits this time as well.

Copy link
Copy Markdown
Member

@jbaublitz jbaublitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good to me. I believe you just need to rebase onto the main branch and then I can approve and merge it.

@jbaublitz jbaublitz removed the status in 2026May May 19, 2026
@jbaublitz jbaublitz moved this to In Progress in 2026May May 19, 2026
@jbaublitz jbaublitz added the enhancement New feature or request label May 19, 2026
@crumblingMizzle crumblingMizzle requested a review from jbaublitz May 19, 2026 19:11
@mulkieran mulkieran added this to the 0.16.0 milestone May 20, 2026
@mulkieran mulkieran moved this from In Progress to In Review in 2026May May 20, 2026
@jbaublitz jbaublitz merged commit eb73055 into stratis-storage:master May 20, 2026
44 checks passed
@github-project-automation github-project-automation Bot moved this from In Review to Done in 2026May May 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants