feat: add number/int64/ctor#13154
Conversation
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
- task: lint_filenames
status: passed
- task: lint_editorconfig
status: passed
- task: lint_markdown_pkg_readmes
status: passed
- task: lint_markdown_docs
status: na
- task: lint_markdown
status: na
- task: lint_package_json
status: passed
- task: lint_repl_help
status: passed
- task: lint_javascript_src
status: passed
- task: lint_javascript_cli
status: na
- task: lint_javascript_examples
status: passed
- task: lint_javascript_tests
status: passed
- task: lint_javascript_benchmarks
status: passed
- task: lint_python
status: na
- task: lint_r
status: na
- task: lint_c_src
status: na
- task: lint_c_examples
status: na
- task: lint_c_benchmarks
status: na
- task: lint_c_tests_fixtures
status: na
- task: lint_shell
status: na
- task: lint_typescript_declarations
status: passed
- task: lint_typescript_tests
status: passed
- task: lint_license_headers
status: passed
---
|
Hello! Thank you for your contribution to stdlib. We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:
This acknowledgment confirms that you've read the guidelines, which include:
We can't review or accept contributions without this acknowledgment. Thank you for your understanding and cooperation. We look forward to reviewing your contribution! |
|
/stdlib update-copyright-years |
@impawstarlight, the slash command failed to complete. Please check the workflow logs for details. |
Coverage Report
The above coverage report was generated for the changes in this PR. |
|
/stdlib update-copyright-years |
@impawstarlight, the slash command failed to complete. Please check the workflow logs for details. |
|
/stdlib update-copyright-years |
@impawstarlight, the slash command failed to complete. Please check the workflow logs for details. |
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
- task: lint_filenames
status: passed
- task: lint_editorconfig
status: passed
- task: lint_markdown_pkg_readmes
status: na
- task: lint_markdown_docs
status: na
- task: lint_markdown
status: na
- task: lint_package_json
status: na
- task: lint_repl_help
status: na
- task: lint_javascript_src
status: passed
- task: lint_javascript_cli
status: na
- task: lint_javascript_examples
status: na
- task: lint_javascript_tests
status: na
- task: lint_javascript_benchmarks
status: na
- task: lint_python
status: na
- task: lint_r
status: na
- task: lint_c_src
status: na
- task: lint_c_examples
status: na
- task: lint_c_benchmarks
status: na
- task: lint_c_tests_fixtures
status: na
- task: lint_shell
status: na
- task: lint_typescript_declarations
status: passed
- task: lint_typescript_tests
status: na
- task: lint_license_headers
status: passed
---
|
@impawstarlight Is there a reason you need to run the |
| b.end(); | ||
| }); | ||
|
|
||
| bench( format( '%s::from', pkg ), function benchmark( b ) { |
There was a problem hiding this comment.
| bench( format( '%s::from', pkg ), function benchmark( b ) { | |
| bench( format( '%s:from', pkg ), function benchmark( b ) { |
There was a problem hiding this comment.
So, single colon for actual method name and double colon for conceptual title?
Co-authored-by: Athan <kgryte@gmail.com> Signed-off-by: Athan <kgryte@gmail.com>
Co-authored-by: Athan <kgryte@gmail.com> Signed-off-by: Athan <kgryte@gmail.com>
| * @param {PositiveInteger} radix - radix (base) to use for string conversion | ||
| * @returns {string} serialized 64-bit unsigned integer | ||
| */ | ||
| function int2str( words, radix ) { |
There was a problem hiding this comment.
Given that this is the same code as in Uint64, maybe as a follow-up PR we should create a separate package which we can then use in both constructor packages. E.g., number/uint64/base/words2string or similar.
There was a problem hiding this comment.
Yeah, that's the plan.
kgryte
left a comment
There was a problem hiding this comment.
Overall, this is looking good. Main quibble is in tightening up the tests. This also applies to number/uint64/ctor which can be addressed in a follow-up PR.
Ah I see. I used do it locally in the past but I somehow got the wrong idea that maybe using the slash command is better from our past meetings and other people's usage. I'll keep it in mind. 😞 |
|
This is from
Is there a just |
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
- task: lint_filenames
status: passed
- task: lint_editorconfig
status: passed
- task: lint_markdown_pkg_readmes
status: na
- task: lint_markdown_docs
status: na
- task: lint_markdown
status: na
- task: lint_package_json
status: na
- task: lint_repl_help
status: na
- task: lint_javascript_src
status: passed
- task: lint_javascript_cli
status: na
- task: lint_javascript_examples
status: na
- task: lint_javascript_tests
status: passed
- task: lint_javascript_benchmarks
status: na
- task: lint_python
status: na
- task: lint_r
status: na
- task: lint_c_src
status: na
- task: lint_c_examples
status: na
- task: lint_c_benchmarks
status: na
- task: lint_c_tests_fixtures
status: na
- task: lint_shell
status: na
- task: lint_typescript_declarations
status: passed
- task: lint_typescript_tests
status: na
- task: lint_license_headers
status: passed
---
Resolves none.
Description
This pull request:
number/int64/ctorRelated Issues
No.
Questions
No.
Other
No.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
N/A.
@stdlib-js/reviewers