Skip to content

fix: refresh specification when updating a visualization description #13148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kgryte merged 1 commit into from
Jun 26, 2026
+2 −2
Merged

fix: refresh specification when updating a visualization description #13148

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions lib/node_modules/@stdlib/plot/base/view/lib/browser/app/schema/transforms/general.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,7 @@ var signalName = require( './../../utils/signal_name.js' );
// VARIABLES //

var PROPS = [
'background',
'description'
'background'
];


Expand Down
1 change: 1 addition & 0 deletions lib/node_modules/@stdlib/plot/base/view/lib/browser/routes/events/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@
var REFRESH_PROPS = [
'width',
'height',
'description',
'labelAlign',
'labelBaseline',
'labelBound',
Expand Down Expand Up @@ -97,7 +98,7 @@
var data;
if ( event ) {
if ( event.source === 'data' ) {
// TODO: handle data change event

Check warning on line 101 in lib/node_modules/@stdlib/plot/base/view/lib/browser/routes/events/main.js

View workflow job for this annotation

GitHub Actions / Lint Changed Files 

Unexpected 'todo' comment: 'TODO: handle data change event'

// NOTE: for data changes, will also need to propagate plot changes (e.g., scales ranges might need updating, etc). Could first send property changes and, once sent, send over data changes.
return;
Expand All @@ -110,7 +111,7 @@
}
counter += 1;

// FIXME: only send the JSON patch

Check warning on line 114 in lib/node_modules/@stdlib/plot/base/view/lib/browser/routes/events/main.js

View workflow job for this annotation

GitHub Actions / Lint Changed Files 

Unexpected 'fixme' comment: 'FIXME: only send the JSON patch'
data = self.spec.toString();

self.events.push({
Expand Down
Loading