Skip to content

fix(ci): Change runner to ubuntu-slim for matrix#20623

Merged
janisz merged 1 commit into
masterfrom
Change-runner-from-ubuntu-latest-to-ubuntu-slim
May 18, 2026
Merged

fix(ci): Change runner to ubuntu-slim for matrix#20623
janisz merged 1 commit into
masterfrom
Change-runner-from-ubuntu-latest-to-ubuntu-slim

Conversation

@janisz
Copy link
Copy Markdown
Contributor

@janisz janisz commented May 15, 2026

Description

User-facing documentation

Testing and quality

  • the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

CI

Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • Consider whether other jobs in this workflow (or related workflows) should also be switched to ubuntu-slim for consistency in environment and performance characteristics, or document why this particular job is different.
  • Since ubuntu-slim is a preview 1-vCPU runner, double-check that all tools and system dependencies used by this job are available there; if any steps rely on preinstalled software from ubuntu-latest, you may need explicit setup steps.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Consider whether other jobs in this workflow (or related workflows) should also be switched to `ubuntu-slim` for consistency in environment and performance characteristics, or document why this particular job is different.
- Since `ubuntu-slim` is a preview 1-vCPU runner, double-check that all tools and system dependencies used by this job are available there; if any steps rely on preinstalled software from `ubuntu-latest`, you may need explicit setup steps.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 15, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Central YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 0285c2fd-4a95-4c63-b266-ce4aeb677d94

📥 Commits

Reviewing files that changed from the base of the PR and between a91a065 and 753b7e3.

📒 Files selected for processing (1)
  • .github/workflows/build.yaml

📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Updated CI/CD pipeline configuration for build optimization.

Walkthrough

The .github/workflows/build.yaml file is updated to change the runner image for the define-job-matrix job from ubuntu-latest to ubuntu-slim.

Changes

CI Runner Configuration

Layer / File(s) Summary
Job matrix runner configuration
.github/workflows/build.yaml
The define-job-matrix job runner selection changes from ubuntu-latest to ubuntu-slim.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: switching the CI runner from ubuntu-latest to ubuntu-slim for the matrix job.
Description check ✅ Passed The description follows the required template with most sections present, including a reference to the GitHub changelog explaining the change, and notes that CI validation is the validation method.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch Change-runner-from-ubuntu-latest-to-ubuntu-slim

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 15, 2026

🚀 Build Images Ready

Images are ready for commit 3d49ddb. To use with deploy scripts:

export MAIN_IMAGE_TAG=4.11.x-1015-g3d49ddb606

Copy link
Copy Markdown
Contributor

@davdhacs davdhacs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great idea! I wonder if there are other jobs we could put onto 1core -slim runners? This alone would help us to reduce our concurrency and be able to run more at once.

@janisz
Copy link
Copy Markdown
Contributor Author

janisz commented May 18, 2026

Yes they are some other jobs.
Release related jobs, periodic checks and nightly tags. Also there are some lint jobs that could be switch. The problem is that we need to run them to verify that everything is installed as slim has less packages so we may need to run steup-go/python/node to provide necessary software.

@janisz janisz merged commit 3d49ddb into master May 18, 2026
104 checks passed
@janisz janisz deleted the Change-runner-from-ubuntu-latest-to-ubuntu-slim branch May 18, 2026 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants