-
Notifications
You must be signed in to change notification settings - Fork 0
ROX-33250: Add support for self-singed CA #121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| {{- if and .Values.centralCACert.cert .Values.centralCACert.existingSecretName }} | ||
| {{- fail "centralCACert: cannot set both 'cert' and 'existingSecretName' — use one or the other" }} | ||
| {{- end }} | ||
| {{- if and .Values.centralCACert.cert (not .Values.centralCACert.existingSecretName) }} | ||
| apiVersion: v1 | ||
| kind: Secret | ||
| metadata: | ||
| name: {{ include "stackrox-mcp.fullname" . }}-central-ca | ||
| labels: | ||
| {{- include "stackrox-mcp.labels" . | nindent 4 }} | ||
| type: Opaque | ||
| data: | ||
| ca.crt: {{ .Values.centralCACert.cert | b64enc }} | ||
| {{- end }} |
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -111,6 +111,11 @@ spec: | |||||||||||||||||||||||||||
| mountPath: /certs | ||||||||||||||||||||||||||||
| readOnly: true | ||||||||||||||||||||||||||||
| {{- end }} | ||||||||||||||||||||||||||||
| {{- if include "stackrox-mcp.centralCAEnabled" . }} | ||||||||||||||||||||||||||||
| - name: central-ca | ||||||||||||||||||||||||||||
| mountPath: /central-ca | ||||||||||||||||||||||||||||
| readOnly: true | ||||||||||||||||||||||||||||
| {{- end }} | ||||||||||||||||||||||||||||
| volumes: | ||||||||||||||||||||||||||||
| - name: config | ||||||||||||||||||||||||||||
| configMap: | ||||||||||||||||||||||||||||
|
|
@@ -121,6 +126,12 @@ spec: | |||||||||||||||||||||||||||
| secretName: {{ include "stackrox-mcp.tlsSecretName" . }} | ||||||||||||||||||||||||||||
| defaultMode: 0440 | ||||||||||||||||||||||||||||
| {{- end }} | ||||||||||||||||||||||||||||
| {{- if include "stackrox-mcp.centralCAEnabled" . }} | ||||||||||||||||||||||||||||
| - name: central-ca | ||||||||||||||||||||||||||||
| secret: | ||||||||||||||||||||||||||||
| secretName: {{ include "stackrox-mcp.centralCASecretName" . }} | ||||||||||||||||||||||||||||
| defaultMode: 0440 | ||||||||||||||||||||||||||||
|
Comment on lines
+129
to
+133
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Make the existing CA secret key configurable.
🔧 Suggested change - name: central-ca
secret:
secretName: {{ include "stackrox-mcp.centralCASecretName" . }}
+ items:
+ - key: {{ default "ca.crt" .Values.centralCACert.existingSecretKey | quote }}
+ path: ca.crt
defaultMode: 0440 centralCACert:
existingSecretName: ""
+ existingSecretKey: "ca.crt"
cert: ""📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I would avoid complicating configuration because this can be set with:
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
It would be worth adding a note in the chart's
|
||||||||||||||||||||||||||||
| {{- end }} | ||||||||||||||||||||||||||||
| {{- with .Values.nodeSelector }} | ||||||||||||||||||||||||||||
| nodeSelector: | ||||||||||||||||||||||||||||
| {{- toYaml . | nindent 8 }} | ||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||
Uh oh!
There was an error while loading. Please reload this page.