test(cmd): prove the verify exit-code contract#606
Merged
Conversation
…d an exit-2 scenario step Signed-off-by: Joshua Temple <joshua.temple@stablekernel.com> (cherry picked from commit 1e5e80366de26c3596286024161fe0079d9bd63c)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The verify exit-code mapping (exitCodeFor: 0=no drift, 1=drift/generic error, 2=operational failure via an ExitCode()-implementing error) had no unit test and no e2e assertion of exit 2, so a regression flipping the mapping would ship silently. The mapping was found correct; this is pure coverage.
Verification: build/test green, 3009 tests, -race on the new tests, e2e schema valid. Pure test-addition.