fix(config): validate matrix dimension keys so an invalid key cannot red the pipeline#605
Merged
Merged
Conversation
…idation time Signed-off-by: Joshua Temple <joshua.temple@stablekernel.com> (cherry picked from commit 0172992)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Matrix dimensions keys were the only emitted identifier class with no validation, so a manifest with a key like 'go version' (a space) passed cascade validation but redded the generated pipeline at first GitHub Actions parse (the key lands raw as a YAML key and in ${{ matrix. }}).
Verification: build/-race/lint green, 3015 tests; 13-case red-then-green validation test; e2e scenario 67-build-matrix exercises a valid matrix (incl. a hyphenated axis) and actionlints clean; no shipped manifest sets dimensions. (Rebased onto main after the injection PR; scenario renumbered to 67.)