refactor: remove dead exported functions and their coverage-only tests#594
Merged
Merged
Conversation
Signed-off-by: Joshua Temple <joshua.temple@stablekernel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes 28 unreachable exported symbols (and their now-orphaned unexported helpers), each confirmed dead by golang.org/x/tools/cmd/deadcode across the whole module and the separate e2e module, together with the coverage-only tests that existed solely to exercise them.
Kept (not dead): QueryJobResults; dependency-injection/test seams (WithClock, WithAncestorFunc, withContentsClient, NewManagerWithURL, Unwrap) and functional options (WithOwnRepo, WithTitle) that are API by design; and every symbol with a meaningful test or an e2e/cmd consumer (EnvNames, hasChanges, NewCalculator, MatchGlobPattern, the pin-scan lint engine, BranchExists, GetLatestReleaseTag, and others). Name collisions were checked: the removed free functions are distinct from retained same-named methods.
Verification: deadcode clean of the removed set; go build + go test ./... compile and pass (2964 tests), -race on affected packages, golangci-lint 0 issues, e2e build/vet/-short green; no golden or testdata changed (pure removal, no output drift).