fix(config): enforce run_policy/on_failure/retries validation on the validate block#589
Merged
Merged
Conversation
…date block Signed-off-by: Joshua Temple <joshua.temple@stablekernel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The manifest validate callback block skipped the run_policy/on_failure enum and retries-bound checks the deploy block enforces, so an invalid enum in a validate block was silently accepted and emitted.
Extracts a shared validateCallbackPolicy helper (run_policy: default/always/force; on_failure: abort/continue; retries 0..3) and routes build/deploy/validate through it, removing three duplicated inline blocks. Pure validation-tightening; generated output unchanged; build/deploy messages unchanged.
Verification: build/-race/lint green, 3056 tests; TestValidate_ValidateBlockPolicyParity covers the four previously-fail-open invalid cases (fail-before/pass-after).