fix(visualize): escape labels, keep repo slugs injective, encode theme values#579
Merged
Conversation
…e values Signed-off-by: Joshua Temple <joshua.temple@stablekernel.com> (cherry picked from commit 2353567d2c05b730e502616937ca4dc15adfdc92)
…tput Signed-off-by: Joshua Temple <joshua.temple@stablekernel.com> (cherry picked from commit a4dc64320e6f6eeac9ac6d6f7b17660f98cdaf95)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: visualize output could statement-split on newline-bearing labels, collide distinct repo slugs into one lane, and emit invalid JSON in the theme init directive.
Fix: fold newlines in node/state/subgraph labels, hash-suffix repo slugs to stay injective, JSON-encode the init directive, and sanitize classDef values. Security-positive (blocks label injection).
Verification: build + visualize/graph/cmd tests green (119 pass), golangci-lint 0 issues; escaping_test + theme_test regression coverage.