feat(vet): allow vet to lint anonymous parameter names

docs/howto/vet.md

@@ -39,6 +39,7 @@ message Query
 message Parameter
 {
   int32 number = 1;
+  string name = 2;
 }
 ```
 
@@ -69,6 +70,7 @@ sql:
       - no-delete
       - only-one-param
       - no-exec
+      - no-anonymous-params
 rules:
   - name: no-pg
     message: "invalid engine: postgresql"
@@ -86,6 +88,10 @@ rules:
     message: "don't use exec"
     rule: |
       query.cmd == "exec"
+  - name: no-anonymous-params
+    message: "don't use anonymous parameters"
+    rule: |
+      query.params.exists(p, p.name == "")
 ```
 
 ### Rules using `EXPLAIN ...` output

internal/cmd/vet.go

@@ -693,6 +693,7 @@ func vetQuery(q *plugin.Query) *vet.Query {
 	for _, p := range q.Params {
 		params = append(params, &vet.Parameter{
 			Number: p.Number,
+			Name:   p.Column.GetName(),
 		})
 	}
 	return &vet.Query{

internal/endtoend/testdata/vet_anonymous_params/exec.json

@@ -0,0 +1,3 @@
+{
+  "command": "vet"
+}

internal/endtoend/testdata/vet_anonymous_params/query.sql

@@ -0,0 +1,7 @@
+-- name: ListByIDs :many
+SELECT id FROM bar
+WHERE id = ANY($1::bigint[]);
+
+-- name: GetByID :one
+SELECT id FROM bar
+WHERE id = $1;

internal/endtoend/testdata/vet_anonymous_params/schema.sql

@@ -0,0 +1 @@
+CREATE TABLE bar (id bigserial NOT NULL);

internal/endtoend/testdata/vet_anonymous_params/sqlc.yaml

@@ -0,0 +1,16 @@
+version: 2
+sql:
+  - schema: "schema.sql"
+    queries: "query.sql"
+    engine: "postgresql"
+    gen:
+      go:
+        package: "querytest"
+        out: "db"
+    rules:
+      - no-anonymous-params
+rules:
+  - name: no-anonymous-params
+    message: "query has an anonymous parameter; name it with sqlc.arg() or @name"
+    rule: |
+      query.params.exists(p, p.name == "")

internal/endtoend/testdata/vet_anonymous_params/stderr.txt

@@ -0,0 +1 @@
+query.sql: ListByIDs: no-anonymous-params: query has an anonymous parameter; name it with sqlc.arg() or @name

internal/endtoend/testdata/vet_anonymous_params_pass/exec.json

@@ -0,0 +1,3 @@
+{
+  "command": "vet"
+}

internal/endtoend/testdata/vet_anonymous_params_pass/query.sql

@@ -0,0 +1,11 @@
+-- name: GetByInferredName :one
+SELECT id FROM bar
+WHERE id = $1;
+
+-- name: GetByArg :one
+SELECT id FROM bar
+WHERE id = sqlc.arg(target_id);
+
+-- name: GetByAtParam :one
+SELECT id FROM bar
+WHERE id = @min_id;

internal/endtoend/testdata/vet_anonymous_params_pass/schema.sql

@@ -0,0 +1 @@
+CREATE TABLE bar (id bigserial NOT NULL);

internal/endtoend/testdata/vet_anonymous_params_pass/sqlc.yaml

@@ -0,0 +1,16 @@
+version: 2
+sql:
+  - schema: "schema.sql"
+    queries: "query.sql"
+    engine: "postgresql"
+    gen:
+      go:
+        package: "querytest"
+        out: "db"
+    rules:
+      - no-anonymous-params
+rules:
+  - name: no-anonymous-params
+    message: "query has an anonymous parameter; name it with sqlc.arg() or @name"
+    rule: |
+      query.params.exists(p, p.name == "")

protos/vet/vet.proto

@@ -4,6 +4,7 @@ package vet;
 
 message Parameter {
   int32 number = 1 [json_name = "number"];
+  string name = 2 [json_name = "name"];
 }
 
 message Config {