Fail fast when trying to build a List with a negative index. #2321
Open
schauder wants to merge 2 commits into
Open
Fail fast when trying to build a List with a negative index. #2321schauder wants to merge 2 commits into
schauder wants to merge 2 commits into
Conversation
Contributor
Author
|
Let me take care of the failing tests. |
This uncovered an inconsistency where lists as selected by single query loading where 1 based where normal lists are 0 based. Fixing this makes up most of the change. Also fixes a bug in one of the integration test sql scripts that surfaced. Closes #2320
Contributor
Author
|
This got a little more involved than expected. @mp911de please have a look. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2320