Proof-of-concept: update to nightly images to include sourcegraph/sourcegraph@e151326#882
Draft
pjlast wants to merge 2 commits into
Draft
Proof-of-concept: update to nightly images to include sourcegraph/sourcegraph@e151326#882pjlast wants to merge 2 commits into
sourcegraph/sourcegraph@e151326#882pjlast wants to merge 2 commits into
Conversation
Contributor
|
Looks good to me! |
mrnugget
changed the title
sourcegraph/sourcegraph@e151326
kopancek
approved these changes
Dec 2, 2022
kopancek
left a comment
kopancek
left a comment
There was a problem hiding this comment.
I see some version changes, looks good to me. That's pretty much all I know about docker-compose 🤷
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft PR so that changes can be reviewed. It is not intended to be merged.
I did a docker-compose up locally to ensure that all the images are being pulled correctly.
This is for a custom docker-compose.yml that points to images built on this commit: https://github.com/sourcegraph/sourcegraph/commit/623cd1da89b3837b9b7df2772d3823ba740ec30a
The
623cd1dpart can be used to verify that the correct images are being used.This is to unblock a trial for a customer that needs the fix to OIDC with TLS that is fixed by this commit, see this Slack thread: https://sourcegraph.slack.com/archives/C032Z79NZQC/p1669917233230879
And this thread: https://sourcegraph.slack.com/archives/C03D4H7UBEV/p1669830116016469