replica: add postgres configuration files into long-running branch#807
Open
kevinwojo wants to merge 1 commit into
Open
replica: add postgres configuration files into long-running branch#807kevinwojo wants to merge 1 commit into
kevinwojo wants to merge 1 commit into
Conversation
Contributor
caugustus-sourcegraph
left a comment
There was a problem hiding this comment.
This PR seems incomplete - doesn't it also require the changes made to the docker volume mounts?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It appears that 3.39 did not include postgres configuration files in the "(changes unrelated to upgrade)" commit.
Context: https://github.com/sourcegraph/customer/issues/854#issuecomment-1109916993
Since new customer-replica branches are based on the previous version's branch, this will be a fix-forward.
Checklist
Test plan
Manually tested, this branch is also more for documentation.