Bumping js-slang to 1.0.92#684
Closed
martin-henz wants to merge 6 commits intomasterfrom
Closed
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request upgrades js-slang to version 1.0.92 and introduces several type-related updates and refactorings across multiple bundles. The reviewer recommends reverting changes in the binary_tree bundle that replaced list, head, and tail abstractions with direct array literals and indexing, as these leak internal implementation details and reduce maintainability.
| export function left_branch(t: BinaryTree): BinaryTree { | ||
| throwIfNotNonEmptyTree(t, left_branch.name); | ||
| return head(tail(t)); | ||
| return t[1][0]; |
There was a problem hiding this comment.
Directly accessing array indices (t[1][0]) leaks the internal implementation details of how lists are represented in js-slang. This makes the code more brittle and harder to maintain. It is recommended to use the head and tail abstractions.
Suggested change
| return t[1][0]; | |
| return head(tail(t)); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrading to 1.0.92 with the help of Claude Code. Several rounds of correction, to pass CICD and get compliance with gemini-code reviews.