Fix AutoSSL connections stalling on pass rules by falling back to passthrough#93
Open
Drewsif wants to merge 1 commit intosonertari:masterfrom
Open
Fix AutoSSL connections stalling on pass rules by falling back to passthrough#93Drewsif wants to merge 1 commit intosonertari:masterfrom
Drewsif wants to merge 1 commit intosonertari:masterfrom
Conversation
…le was configured. The connection now correctly falls back to the passthrough protocol and processes any buffered client data. - fix(ssl): Fall back to passthrough protocol when a `pass` rule is configured for autossl - fix(passthrough): Process buffered source data after switching from another protocol
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
What does this PR do?
This PR updates the protocol handling logic to correctly fall back to the passthrough protocol when a
passrule or passthrough option is configured during AutoSSL connections.What problem does it solve or what feature does it add?
It fixes an issue where AutoSSL connections would stall when a
passrule was matched. Previously, the connection would stall or terminate. Now, it falls back to passthrough and ensures that any buffered client (source) data is properly processed after switching protocols.Is this related to an open issue? If so, reference it here.
N/A
Checklist
make testor equivalent).Additional Information
Any special instructions for testing?
To verify, configure an AutoSSL setup with a
passrule for a specific connection. Ensure that the connection succeeds and does not stall, and that any initial data sent by the client before the protocol switch is correctly forwarded.Screenshots, logs, or other supporting materials, if applicable.
When the fallback occurs, a warning log
Falling back to passthroughwill be recorded, and the source buffer will be checked and processed if its length > 0.